Atttze
Feb 17th

  In Firefox (maybe more browsers) the
in the code block above at line 22 is 'hidden'...

Atttze
Feb 17th

   According to the PHP docs it should be:

1

var breakTag = (is_xhtml || typeof is_xhtml === 'undefined') ? '' : '<br>';

1

var breakTag = (is_xhtml || typeof is_xhtml === 'undefined') ? '' : '<br>';

Brett Zamir
14 Nov '09

  @Maximusya: Good catch--fixed in http://github.com/kvz/phpjs/commit/cc8835a98b175ad7038fcd64c85936f3bea8bdbb

Maximusya
13 Nov '09

   Taking into account different newline combinations (\r\n, \r, \n), function should return

1

return (str + '').replace(/([^>\r\n]?)(\r\n|\n\r|\r|\n)/g, '$1'+ breakTag +'$2');

Kevin van Zonneveld
14 Jan '09

  @ John Peterson: Of course: that's not at all like PHP. And that's what we're trying to recreate here: So the main version should be as is it right now.

However. Just like there's a namespaced version of PHP.JS, I think it should be possible for us to generate prototype versions with the compiler.

Currently this is a low priority for me and I would first like to create a public interface to the compiler on the phpjs.org site.

But I will keep this in mind as a future feature!

Brett Zamir
14 Jan '09

  I should add the extra qualification that overloading the Object or Array prototype would probably be quite objectionable to many and need some serious revising of the PHP-JS functions (which I'm thinking should probably be revised regardless) to check for hasOwnProperty in each iterating for loop.

Brett Zamir
14 Jan '09

  HI John,

I think concerns on this range from "What happens if a standard version gets implemented later?" to "Will this interfere with other implementations added to the prototype (as a kind of "global" problem?"), etc.. However, I personally think this could be very convenient for those willing to take the risk (or who reset the prototype after their code is done with it).

Maybe when we get the string functions done ( ;) ), we can make one version of the PHP-JS package which adds to the prototype (also for Array, Object, Number, or maybe Function or Boolean if you can think of a reason!), as I'm hoping we can see a configurable version made at some point (as an independent project, if not through Kevin's official version).

John Peterson
14 Jan '09

   Why not just do this so much simplier...

String.prototype.nl2br = function() {
var breakTag = '<br />';
return (this + '').replace(/([^>]?)\n/g, '$1'+ breakTag +'\n');
}

then you can just do:

mystring.nl2br()

Kevin van Zonneveld
13 Oct '08

  @ Atli Þór: That's a Great contribution Atli Þór. I wish I could give your more credit, than the current system can give you. Thanks man.

Atli Þór
10 Oct '08

  Not sure why my last post got messed up like that.
If it was bad formatting on my part I apologize.

Atli Þór
10 Oct '08

   Hi.

There seems to be a minor flaw in the function for strings that start with a line-breaks, or have multiple consecutive line-breaks.

Using this:
[code="text"]nl2br("\nOne\nTwo\n\nThree\n")[/code]
it leaves out the first new-line and replaces the two new-lines between "Two" and "Three" with a single break.

Making the regex non-greedy seems to fix this tho:

1

return (str + '').replace(/([^>]?)\n/g, '$1<br />\n');

1
2
3
4
56
7

function nl2br( str, is_xhtml ) {
    breakTag = "<br />";
    if(typeof is_xhtml == "boolean" || is_xhtml == false) {
        breakTag = "<br>";
    }    return (str + '').replace(/([^>]?)\n/g, '$1'+ breakTag +'\n');
}

Kevin van Zonneveld
29 Sep '08

  @ Onno Marsman: Nice :) Function has been updated according to your proposal!

Onno Marsman
26 Sep '08

  lol, still no good. Kevin: you know what I mean. I've only added (str+'')

Onno marsman
26 Sep '08

   I guess html is not escaped correctly, I meant:

1
2
3

function nl2br( str ) {
    return (str+'').replace(/([^>])\n/g, '$1<br />\n');
}

Onno Marsman
26 Sep '08

   To make sure it's a string i.e. nl2br(6):

1
2
3

function nl2br( str ) {
     return (str+'').replace(/([^>])\n/g, '$1<br />\n');
}

Music Russia
8 Sep '08

   Sorry, Kevin, that's just my stupid mistake, i confused one var with another. I spend about 15 minutes until figured it out.

Here's the part of my code and it 100% works now:

1
2
3

var nfull = document.getElementById('full').value;
nfull = nfull.replace(/([^>])\\n/g, '$1<br />');
document.getElementById('txtpr').innerHTML = nfull;

Kevin van Zonneveld
8 Sep '08

  @ Music Russia: Please be more specific, can you for example provide the code how you call it? And explain what breaks? Thanks a lot!

Music Russia
6 Sep '08

  Do not work in my case.

Kevin van Zonneveld
21 May '08

  @ Joshua: Thank you, we're still working on a tool to customize & save your own php.js version, maybe that would be something for you then!

Joshua
21 May '08

  Nice piece of js code, very usefull :) I'm not using the whole package but just little pieces of code, great work!

Kevin van Zonneveld
15 Apr '08

  @ Philip Peterson: I've updated the function with your suggestions. Thank you!

Philip Peterson
15 Apr '08

  There are a few inconsistencies here:

first off, the replacement text should be "<br />\n" (with the space before the backslash in <br /> and including the newline). Also, I don't have time to do this, but you may want to check out how PHP handles \r\n and \r in this function, as it may be useful to implement support for if the PHP function does it.