Brett Zamir
Feb 4th

  @nitin gupta: Thanks--I've fixed it in Git. I think it is a relic of the fact that we noticed that we may still _need_ to sort according to the docs, but I'm a bit busy to look at fixing this now myself.

nitin gupta
Feb 2nd

  Hi Kevin,

I do not see this function being dependent on asort, may be a little documentation error.

Regards,

Kevin van Zonneveld
14 Apr '09

  Great work guys, I'll deploy shortly

Brett Zamir
14 Apr '09

  Ok, I made the strict fix, Michael, in SVN, thank you!

However, I'm not sure about the array-to-objects issue. Although we can get an array to return, due to the nature of JS, it will only contain the numerically indexed items within the array (and the length will be the total of those only). The other items would be added as properties of that array's object, and not be counted with length, though they are iteratable. Kevin has chosen to implement PHP arrays as regular (non-array) objects, so that we can support associative arrays. Granted we could theoretically return arrays with object properties, but that might be more confusing, and perhaps is the reason he chose not to do that.

One solution, might be to detect whether the input array was indeed a genuine array (which could only be numerically indexed), and if so, build a bona fide array as output too, but the problem with that is that the PHP behavior is to preserve keys, and we cannot preserve keys unless we build an object (or delete/cause to be undefined, those items which are no longer in use, but that still keeps the array length)--the one rare exception where we could safely return a regular array would be if all of the unique items were at the front of the array... So, not any good answers, I suspect, though I imagine you personally should be able to adapt the output of our function to the form you need for Greasemonkey... Best wishes, Brett

Michael Grier
13 Apr '09

   I found out if you're using this in GreaseMonkey, objects won't return. I changed the tmp_arr declarations to array, and it started working for me.

Also, regarding the strict var, PHP always does a strict comparison after casting the arguments to strings. So you could do the following:

1
2
3

if ((haystack[fkey] + "") === (needle + "")) {
    return fkey;
}

Kevin van Zonneveld
9 Nov '08

  @ Nate: Thank you for noticing!

Nate
6 Nov '08

   It looks like someone forgot to declare "val" with var.

I think the first line of code should read:

1

var key = '', tmp_arr1 = {}, tmp_arr2 = {}, val;

Kevin van Zonneveld
27 Aug '08

  @ Nosredna: That's an idea that calls for a function rewrite. Interested? ;)

Nosredna
5 Aug '08

  Stray thought. The nested loops make me wonder how slow this is for large arrays.

Perhaps you could clone the array, sort the clone, then walk the two arrays deleting the dupes as you go. Sort is probably O(n log n) and maybe it's especially fast when no user sort evaluation routine is passed in.

Kevin van Zonneveld
25 Jul '08

   @ sankai: Thank you so much! But this array_unique does not support associative arrays (javascript objects). So unlike PHP's implementation, arrays that have non-numeric keys do not work.

Sad to say that my implementation didn't support it either, but I'm looking to replace array_unique with one that does support:

1

{firstname: 'Kevin', surname: 'van Zonneveld'}

sankai
25 Jul '08

   the code I posted yesterday had big bug!I fixed it as the following:

1
2
3
4
56
7
8
9
1011
12
13
14
1516
17
18
19
2021
22
23

function array_unique(array,numeric){
    // http://blog.doublekai.org/
    // +   original by: sankai (http://blog.doublekai.org/)
    // *     example 1: array_unique([1,2,3,'1','2','3',1,2,3],true);
    // *     returns 1: [1,2,3]    // *     example 2: array_unique([1,2,3,'1','2','3',1,2,3]);
    // *     returns 2: [1,2,3,'1','2','3']
    // *     example 3: array_unique([1,'a','a','1','3',3,'b','c','b',1]);
    // *     returns 3: [1,'a','1','3',3,'b','c']
    // *     example 3: array_unique([1,'a','a','1','3',3,'b','c','b',1],true);    // *     returns 3: [1,'a',3,'b','c']    
    // *     NOTE :require function in_array()    
    var tem_arr = new Array();
    for(i=0;i<array.length;i++){
        if(numeric === true && typeof(array[i]) == 'string' && !isNaN(array[i])){             array[i]=parseInt(array[i],10);
        }
        if(!in_array(array[i],tem_arr)){
                tem_arr[i]=array[i];
        }    }
    return tem_arr.join(' ').replace(/\s{2,}/g,' ').split(' ');
}

1
2
3
4
56
7
8
9
1011
12
13
14
1516
17
18
19
2021
22
23
24
2526
27
28
29
3031
32
33
34
35

function array_unique(array,numeric){
    // http://blog.doublekai.org/
    // +   original by: sankai (http://blog.doublekai.org/)
    // *     example 1: array_unique([1,2,3,'1','2','3',1,2,3],true);
    // *     returns 1: [1,2,3]    // *     example 2: array_unique([1,2,3,'1','2','3',1,2,3]);
    // *     returns 2: [1,2,3,'1','2','3']
    // *     example 3: array_unique([1,'a','a','1','3',3,'b','c','b',1]);
    // *     returns 3: [1,'a','1','3',3,'b','c']
    // *     example 3: array_unique([1,'a','a','1','3',3,'b','c','b',1],true);    // *     returns 3: [1,'a',3,'b','c']    
    // *     DON'T NEED require function in_array()    
    var tem_arr = new Array();
    for(i=0;i<array.length;i++){
        if(numeric === true && typeof(array[i]) == 'string' && !isNaN(array[i])){             array[i]=parseInt(array[i],10);
        }    
        if(tem_arr.length == 0){
            tem_arr[i] = array[i];
        } else {            var exist = false;
            for(var j=0; j<tem_arr.length; j++){
                if(tem_arr[j] === array[i]){
                    exist = true;
                }            }
            if(!exist){
                if(array[i] != null){
                    tem_arr[i] = array[i];
                }                }
        }
    }
    return tem_arr.join(' ').replace(/\s{2,}/g,' ').split(' ');
}

sankai
24 Jul '08

   Hi,I try to write a code for array_unique() as the following:

1
2
3
4
56
7
8
9

function array_unique(array){
    var tem_arr = new Array();
    for(i=0;i<array.length;i++){
        if(!in_array(array[i],tem_arr)){
            tem_arr[i]=array[i];        }
    }
    return tem_arr.join(',').split(',');
}

sankai
24 Jul '08

   Running:

1

array_unique(['Kevin','Kevin','van','Kevin']);

1

['Kevin','van','Kevin']

Kevin van Zonneveld
16 Jun '08

  @ goshki: You're right, it seems that our current version doesn't support associative arrays (javascript objects). Since PHP doesn't distinct those, we need to work on a version that does support objects. It's on my todo list. Thank your for noticing!

goshki
13 Jun '08

   Well, there seems to be some kind of a problem with this function. Running:

1

array_unique(['a','b','c','a','b','c','a','b','c']);

1

['a','a','b','c']

Kevin van Zonneveld
2 May '08

  @ duncan: You were not being stupid, we were. Thank you for noticing! The fixed version will be visible shortly.

duncan
30 Apr '08

  maybe i'm being stupid, but PHP array_unique returns an array, not a boolean.
"Takes an input array and returns a new array without duplicate values."